Add benchmarks and optimize html5lib a bit #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 90.97% 91.11% +0.14%
==========================================
Files 49 50 +1
Lines 6936 7036 +100
Branches 1322 1340 +18
==========================================
+ Hits 6310 6411 +101
- Misses 468 471 +3
+ Partials 158 154 -4
Continue to review full report at Codecov.
|
jgraham
reviewed
Jun 5, 2020
These tests are based on two things: some from WPT, and some based on Anolis
This has a _significant_ effect on parser creation time
Mostly so we have test coverage here on < 3.7
|
@jgraham I think this can land now? |
This was referenced Jun 10, 2020
Closed
jgraham
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full revision by revision changes:
(Note that the intermediate versions were done with vastly fewer data points, so some of these may appear significant when they're not)
Essentially, the majority of the gains come from avoiding the entire meta pre-parse when the pre-parse range doesn't contain
<metaand from only initializing the method dispatcher once (and merely binding it to the phase instance when that is created; this is especially significant when parsing small inputs as it is constant overhead).